Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises/practice/anagram: add an append with instructions about the order of the return values #932

Closed
wants to merge 1 commit into from

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Jan 15, 2025

No description provided.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

Clarify what this track expects. Context: https://forum.exercism.org/t/14816/

@IsaacG
Copy link
Member Author

IsaacG commented Jan 18, 2025

+cc @vaeng

@vaeng
Copy link
Contributor

vaeng commented Jan 18, 2025

Wow, what a long winded discussion. I'd rather think about a solution, that accepts the old solution but also sets etc.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 18, 2025

I'd rather think about a solution, that accepts the old solution but also sets etc.

If possible, using a set or sorting the values would do the trick!

@ahans
Copy link
Contributor

ahans commented Jan 18, 2025

@vaeng I can take care of this. Have been too inactive here lately...

@ahans
Copy link
Contributor

ahans commented Jan 18, 2025

I opened a PR (#933) for this that allows an arbitrary order. But honestly, I think I like the append better. Ending up with a different order would be quite unnatural anyway, so clarifying the instructions is the way to go? I must admit I haven't read the entire thread (yet), and reading the comment here again, I wonder if this is about accepting also a solution that would return a set? We could sure do that. It would complicate the test a bit further, but maybe that's acceptable? @vaeng If you had something else in mind, let's discuss over at #933. But I'd also be fine with merging this and just closing #933.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 19, 2025

I opened a PR (#933) for this that allows an arbitrary order. But honestly, I think I like the append better.

I think allowing any order makes more sense, to be honest :) While this order seems the most reasonable, I don't think a different order should be wrong. But also, I'm not a track maintainer here.

@ahans
Copy link
Contributor

ahans commented Jan 20, 2025

Closing in favor of #933.

@ahans ahans closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants